Skip to content

fix(formatting) Fix JSX element in prop object recursive loop #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2018
Merged

fix(formatting) Fix JSX element in prop object recursive loop #309

merged 1 commit into from
Sep 27, 2018

Conversation

samwalshnz
Copy link
Contributor

@samwalshnz samwalshnz commented Sep 13, 2018 •
edited
Loading

Now supports:

<Component
	props={{
		subcomponent: <AnotherComponent />,
	}}
/>

Fixes #307

@ghost
Copy link

ghost commented Sep 13, 2018

There were the following issues with this Pull Request

  • Commit: 363b29f
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@samwalshnz
fix(formatting): Fix JSX element in prop object recursive loop
61e042b 
Now supports:
<Component
	props={{
		subcomponent: <AnotherComponent />,
	}}
/>
@samwalshnz samwalshnz force-pushed the sortobject-recursive-loop branch from 363b29f to 61e042b Compare September 13, 2018 01:53
@thomasbertet
Copy link
Contributor

thomasbertet commented Sep 24, 2018 •
edited
Loading

I tested this fix on my project and it works fine, thanks !

@thomasbertet
Copy link
Contributor

@vvo sorry to ping you directly. I saw you handled the last version updates on this repo.
Are you still maintaining this project or should we maybe fork/help in any way ? I noticed some PRs waiting for some time, I just want to know the status so I can act accordingly. Please do not feel pressed in any way 👍

@vvo
Copy link
Contributor

vvo commented Sep 25, 2018

@thomasbertet pinging me is completely OK for those cases and any other Algolia project.
I am not using it nor maintaining it effectively, I got some help at some point. Would you like to help maintaining it and releasing?

@vvo
Copy link
Contributor

vvo commented Sep 25, 2018

This PR is only missing a test

@thomasbertet
Copy link
Contributor

@samwalshnz are you willing to update your PR with a test case ?
If not, I could try to do it.

@vvo I'm not really used to maintain & release OSS, but I offer my help periodically when I find the time.
Moreover, I believe I have not enough understanding of this code base to be able to maintain it effeciently. What I can do though is helping in making this fix happen :)

@vvo
Copy link
Contributor

vvo commented Sep 27, 2018

@thomasbertet I can merge this and then you add a PR for tests if that works, please do so then we will release. Adding a tests you can just follow previous tests cases

@vvo vvo merged commit fd4f53b into algolia:master Sep 27, 2018
@samwalshnz
Copy link
Contributor Author

@thomasbertet Sorry, I'm swamped here at work atm and don't have time to PR with some tests. If you wouldn't mind writing some tests for me, that would be awesome 🙏

@samwalshnz samwalshnz deleted the sortobject-recursive-loop branch October 2, 2018 23:12
@thomasbertet thomasbertet mentioned this pull request Oct 4, 2018
Merged
@thomasbertet
Copy link
Contributor

@samwalshnz I wrote some #312 . If you have time to check if that's what you had in mind, please do :)

@SachsKaylee
Copy link
Collaborator

Included in 14.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samwalshnz @thomasbertet @vvo @SachsKaylee